Skip to content

Conversation

Skn0tt
Copy link
Contributor

@Skn0tt Skn0tt commented Nov 9, 2023

The logic for detecting all files in a directory was off, and generated wrong paths. This resulted in wrong paths being excluded. This PR fixes that, and adds a very simple unit test setup to prove it.

@Skn0tt Skn0tt requested a review from julienp November 9, 2023 10:46
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for plugin-angular-universal-demo ready!

Name Link
🔨 Latest commit 9b4accf
🔍 Latest deploy log https://app.netlify.com/sites/plugin-angular-universal-demo/deploys/654cf69293b0f3000809a858
😎 Deploy Preview https://deploy-preview-74--plugin-angular-universal-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 9, 2023
@@ -74,7 +74,7 @@ Keep in mind that these will not be available on the client-side or during [prer
To test this in local development, run your Angular project using `netlify serve`:

```sh
netlify serve --dir dist/<your-project-name>/browser
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a follow-up to #67 (comment)

@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 9, 2023

looks like the CI needs some tending

@Skn0tt Skn0tt marked this pull request as draft November 9, 2023 10:49
@Skn0tt Skn0tt marked this pull request as ready for review November 9, 2023 13:10
@Skn0tt
Copy link
Contributor Author

Skn0tt commented Nov 9, 2023

7b8c1fb contains an update to the minimum supported version of Node.js. This could technically be seen as a breaking change, but given that Angular compilation would fail anyways on Node versions below that, I believe it's fine to put this in a patch update.

@Skn0tt Skn0tt self-assigned this Nov 9, 2023
@Skn0tt Skn0tt merged commit 5843bc8 into main Nov 9, 2023
@mrstork mrstork deleted the fix-excludedPath branch May 30, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants