Skip to content

fix: handle deploy-scoped stores on Windows #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Conversation

eduardoboucas
Copy link
Member

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for blobs-js ready!

Name Link
🔨 Latest commit 533188b
🔍 Latest deploy log https://app.netlify.com/sites/blobs-js/deploys/65607692832026000894e56a
😎 Deploy Preview https://deploy-preview-119--blobs-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 24, 2023
@eduardoboucas eduardoboucas marked this pull request as ready for review November 24, 2023 10:18
@eduardoboucas eduardoboucas requested a review from a team as a code owner November 24, 2023 10:18
@@ -286,3 +286,28 @@ test('Lists entries', async () => {

expect(parachutesSongs2.directories).toEqual([])
})

test('Works with a deploy-scoped store', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have committed this test first and you can see it failing: d746898

@eduardoboucas eduardoboucas merged commit e96286d into main Nov 24, 2023
@eduardoboucas eduardoboucas deleted the fix/server-windows branch November 24, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants