Skip to content

[WRFL-2471] puppeteer upgrade #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[WRFL-2471] puppeteer upgrade #624

wants to merge 8 commits into from

Conversation

aitchiss
Copy link
Contributor

@aitchiss aitchiss commented May 14, 2025 •
edited
Loading

This change is very similar to a previous one we had to revert in #544, but with some key differences:

  • Upgrades to an even more recent version of puppeteer
  • The minimum node version for this plugin was set to 18.14.0 earlier this year, and the previous issues with this change were only applicable to very old node versions (e.g. 12x)

Steps to test:

  • Using one of your netlify sites, set the dependency for the lighthouse plugin to use this branch, e.g. "@netlify/plugin-lighthouse": "https://github.com/netlify/netlify-plugin-lighthouse.git#sa/upgrade-puppeteer-with-cache-utils"
  • Verify you can run deploys successfully at a range of supported node versions

@netlify Netlify
Copy link

netlify bot commented May 14, 2025 •
edited
Loading

👷 Deploy Preview for plugin-lighthouse processing.

Name Link
🔨 Latest commit f254253
🔍 Latest deploy log https://app.netlify.com/projects/plugin-lighthouse/deploys/68304781991e7f0008566d6a

@aitchiss aitchiss marked this pull request as ready for review May 14, 2025 15:41
@aitchiss aitchiss requested a review from a team as a code owner May 14, 2025 15:41
@aitchiss aitchiss self-assigned this May 14, 2025
cmparsons
cmparsons previously approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@cmparsons cmparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Node 18, 20, and 22 and worked on my projects 👍

I noticed that some logs are duplicated. Is this expected?

CleanShot 2025-05-14 at 11 17 01@2x
CleanShot 2025-05-14 at 11 17 08@2x

@aitchiss
Copy link
Contributor Author

I noticed that some logs are duplicated. Is this expected?

That's definitely strange - I'll see if I can figure out what's going on there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmparsons cmparsons cmparsons left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@aitchiss aitchiss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aitchiss @cmparsons