Skip to content

Conversation

colbyfayock
Copy link
Contributor

Are you adding a plugin or updating one?

  • Adding a plugin
  • Updating a plugin

Have you completed the following?

Updates Cloudinary version to 1.10.2 to address a bug that uses the wrong Netlify URLs for deployed images.

The URL used now reflects:

  let host = process.env.URL;

  if ( process.env.CONTEXT === 'branch-deploy' || process.env.CONTEXT === 'deploy-preview' ) {
    host = process.env.DEPLOY_PRIME_URL || ''
  }

This unfortunately hasn't been tested in a prod-like environment beyond local development with --context production and using the Netlify Cloudinary project which builds with the latest plugin version by using the locally referenced version as I can't pin, but sounds like that will change with the new SDK for testing purposes.

@colbyfayock colbyfayock requested a review from a team as a code owner September 19, 2023 18:51
@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for netlify-plugins ready!

Name Link
🔨 Latest commit f2792fe
🔍 Latest deploy log https://app.netlify.com/sites/netlify-plugins/deploys/6509edc7b6bd98000848e3e7
😎 Deploy Preview https://deploy-preview-1257--netlify-plugins.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodiakhq kodiakhq bot merged commit 8cbab74 into netlify:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants