Session affinity scorer #52
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
elevran
requested changes
Apr 27, 2025
There was a problem hiding this comment.
This file seems like it belongs to a different PR and not to a session affinity scorer
| isFirst := true | ||
|
|
||
| for _, pod := range pods { | ||
| if isFirst { |
There was a problem hiding this comment.
There is no reason to test isFirst on every iteration, by doing some work outside the loop:
- set the first pod and its score as the maximum Pod and score
- set
maxScore = -math.MaxFloat64
| ctx.Logger.V(logutil.DEBUG).Info(fmt.Sprintf("Selecting a pod with maximum score from %d candidates: %+v", len(pods), pods)) | ||
|
|
||
| // select pod with maximum score, if more than one with the max score - use random pods from the list | ||
| var highestScoreTargets []types.Pod |
There was a problem hiding this comment.
nit: not sure if it makes sense to have such long variable names in a relatively short function. I don't think we have a style guide, but Go seems to favor shorter names in smaller scopes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Session affinity scorer uses information stored in datastore (map of session id to pod) to set score=1 to pod for the given session id (if exists) or 0 to all other pods