fix: Correct the setup of the KGateway Envoy service to be a proper NodePort service #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gateway controller)
elevran
approved these changes
Apr 24, 2025
| labels: | ||
| gateway.istio.io/managed: istio.io-gateway-controller | ||
| app.kubernetes.io/instance: inference-gateway |
There was a problem hiding this comment.
are these needed, filled in automatically by RHOS?
If not needed, it may be better to remove so we keep files to their minimum and it is clear what's needed. Otherwise people continue copying in fear of breaking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects setup of the KGateway Envoy's service to be a proper NodePort service.
To do this:
by itself is not enough, as one can't set the nodePort that the service will be mapped to.