feat: add cleanup for kubernetes dev env #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
reviewed
Apr 24, 2025
| ```sh | ||
| make clean.environment.dev.kubernetes | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Suggested change
| > **Warning**: This cleanup doesn't remove any custom pull `Secrets` you may have added. If you are | |
| > done with this environment, you may want to remove those manually as well. | |
Makefile
Outdated
| # ------------------------------------------------------------------------------ | ||
| .PHONY: clean.environment.dev.kubernetes | ||
| clean.environment.dev.kubernetes: check-kubectl check-kustomize check-envsubst | ||
| ifndef NAMESPACE | ||
| $(error "Error: NAMESPACE is required but not set") | ||
| endif | ||
| @echo "INFO: deleting namespace $(NAMESPACE)" | ||
| kubectl delete namespace $(NAMESPACE) | ||
| @echo "INFO: deleting namespace dev environments from $(NAMESPACE)" |
There was a problem hiding this comment.
Suggested change
| @echo "INFO: deleting namespace dev environments from $(NAMESPACE)" | |
| @echo "INFO: cleaning up dev environment in $(NAMESPACE)" |
There was a problem hiding this comment.
I think you might need to push, I can't see any updates?
|
@shaneutt, done with all the fixes. |
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cleanup instructions for DEPLOYMENT.md for the development environment