feat: Add scripts for kubernetes dev env using vLLM and vLLM-p2p #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
requested changes
Apr 25, 2025
deploy/environments/dev/kubernetes-kgateway/gateway-parameters.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,11 @@ | |||
| apiVersion: kustomize.config.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
Oh ok, I see what you're doing with the naming now. The difference now is that any one of these deployments is deploying only a working VLLM stack, and then you have to deploy your inference-gateway stack separately.
cc @tumido @Gregory-Pereira @vMaroon just wanting to check with you on how this will work with your Helm chart?
vMaroon
reviewed
Apr 25, 2025
fc98576 to
1a7fa8e
Compare
390c50a to
b189362
Compare
|
@shaneutt , PTOL. |
elevran
reviewed
Apr 27, 2025
deploy/environments/dev/kubernetes-kgateway/gateway-parameters.yaml
Outdated
Show resolved
Hide resolved
shaneutt
reviewed
Apr 28, 2025
deploy/environments/dev/kubernetes-vllm/vllm/kustomization.yaml
Outdated
Show resolved
Hide resolved
elevran
approved these changes
Apr 29, 2025
|
@kfirtoledo LGTM, any idea on the CICD failure? |
…tup for kvcache-aware) Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Kubernetes environment development using GIE with KGateway and vLLM
This PR introduces support for the
vllmmode, enabling integration testing of GIE with vLLM.It also adds support for the
vllm-p2pmode, which includes: