Add load based scorer #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevran
approved these changes
Apr 28, 2025
| func (s LoadBasedScorer) Score(ctx *types.SchedulingContext, pods []types.Pod) map[types.Pod]float64 { | ||
| var scoredPods map[types.Pod]float64 = make(map[types.Pod]float64) | ||
|
|
||
| for _, pod := range pods { |
There was a problem hiding this comment.
Suggested change
| for _, pod := range pods { | |
| for pod := range pods { |
| // Score 0 will get pod with number of requests in the queue qual to the threshold used in load-based filter (QueueingThresholdLoRA) | ||
| // In future pods with additional capacity will get score higher than 0.5 | ||
| func (s LoadBasedScorer) Score(ctx *types.SchedulingContext, pods []types.Pod) map[types.Pod]float64 { | ||
| var scoredPods map[types.Pod]float64 = make(map[types.Pod]float64) |
There was a problem hiding this comment.
nit: score would have been a good variable name as well (and shorter):
scorePods[pod] = ... is repetitive, IMHO, and score[pod] = ... is just as readable.
unclear what issue reference that is intended to do in the commit comment. |
|
Fix #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load-based scorer is based on number of requests in the waiting queue.
It completes the LowQueueFilter, pods with number of waiting requests higher than a threshold is filtered out, pods with number of waiting requests lower than the threshold gets score below 0.5
Ref #66