Added support for plugins to receive request headers and to modify the headers that are finally forwarded #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
* removed unused noop plugin Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * more scheduler refactoring Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * more refactoring Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * added weights to scorers and calculating weighted score Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * addressed code review comments Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
…est headers and to be able to add request headers
mayabar
requested changes
Apr 29, 2025
|
Partially fixes issue #73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the PreSchedule, Filter, Scorer, Picker, and PostSchedule plugins to receive all of the headers sent by the user in their request. This enables the writing of plugins that make use of additional headers.
In addition, this PR adds support for the above plugins to add and/or modify the headers in the user's request. This is needed in certain solutions of Disaggregated Prefill/Decode.
The unit tests added are very simplistic. A better unit test will be added later at the StreamingServer level