Skip to content
This repository was archived by the owner on May 15, 2025. It is now read-only.

test: Test load based scorer #81

Merged
merged 2 commits into from
Apr 30, 2025
Merged

test: Test load based scorer #81

merged 2 commits into from
Apr 30, 2025

Conversation

irar2
Copy link

@irar2 irar2 commented Apr 29, 2025

#80

@irar2 irar2 requested review from mayabar and shmuelk April 29, 2025 08:29
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
scheduler := NewScheduler(&fakeDataStore{pods: test.input})
scheduler.scorers[test.scorer] = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not set the set of scorers to be just what is in the test. At the moment there are no scorers in the default scheduler config, but this could change. It could be better to do the following:

scheduler,scorers = map[plugins.Scorer]int{test.scorer: 1}

This will also help when you another scorer to be tested

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@irar2 irar2 merged commit 128d901 into neuralmagic:dev Apr 30, 2025
@irar2 irar2 deleted the load-test branch April 30, 2025 05:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants