Skip to content

Read pod role from kubernetes pod info in reconciler #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

Read pod role from kubernetes pod info in reconciler #82

merged 3 commits into from
Apr 29, 2025

Conversation

mayabar
Copy link
Collaborator

@mayabar mayabar commented Apr 29, 2025

Ref #78

@mayabar mayabar requested review from elevran and shmuelk April 29, 2025 10:59
shmuelk
shmuelk approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@shmuelk shmuelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

elevran
elevran approved these changes Apr 29, 2025
View reviewed changes
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for unit tests

@mayabar
Copy link
Collaborator Author

mayabar commented Apr 29, 2025

we will add unittests in a separate PR

@mayabar mayabar merged commit 989cfe8 into neuralmagic:dev Apr 29, 2025
1 check passed
@mayabar mayabar deleted the pd-label branch April 30, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elevran elevran elevran approved these changes

@shmuelk shmuelk shmuelk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayabar @elevran @shmuelk