-
Notifications
You must be signed in to change notification settings - Fork 7
Dev rebase 2025 04 29 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com>
pkg/epp/scheduling/scheduler_test.go
Outdated
name: "filter all", | ||
name: "all plugins executed successfully, different scorers weights", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shmuelk changed by mistake?
the previous test name is all plugins executed successfully, different scorers weights
. line 330 should stay filter all
(this is what the test validates).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
* embedded Pod interface into ScoredPod struct. updated tests and picker accordingly Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> * implemented max-score picker Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com> * minor changes in max score picker Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> --------- Signed-off-by: Nir Rozenbaum <nirro@il.ibm.com> Signed-off-by: Maroon Ayoub <maroon.ayoub@ibm.com> Co-authored-by: Maroon Ayoub <maroon.ayoub@ibm.com>
Bumps the kubernetes group with 6 updates: | Package | From | To | | --- | --- | --- | | [k8s.io/api](https://github.com/kubernetes/api) | `0.32.3` | `0.32.4` | | [k8s.io/apiextensions-apiserver](https://github.com/kubernetes/apiextensions-apiserver) | `0.32.3` | `0.32.4` | | [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) | `0.32.3` | `0.32.4` | | [k8s.io/client-go](https://github.com/kubernetes/client-go) | `0.32.3` | `0.32.4` | | [k8s.io/code-generator](https://github.com/kubernetes/code-generator) | `0.32.3` | `0.32.4` | | [k8s.io/component-base](https://github.com/kubernetes/component-base) | `0.32.3` | `0.32.4` | Updates `k8s.io/api` from 0.32.3 to 0.32.4 - [Commits](kubernetes/api@v0.32.3...v0.32.4) Updates `k8s.io/apiextensions-apiserver` from 0.32.3 to 0.32.4 - [Release notes](https://github.com/kubernetes/apiextensions-apiserver/releases) - [Commits](kubernetes/apiextensions-apiserver@v0.32.3...v0.32.4) Updates `k8s.io/apimachinery` from 0.32.3 to 0.32.4 - [Commits](kubernetes/apimachinery@v0.32.3...v0.32.4) Updates `k8s.io/client-go` from 0.32.3 to 0.32.4 - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.32.3...v0.32.4) Updates `k8s.io/code-generator` from 0.32.3 to 0.32.4 - [Commits](kubernetes/code-generator@v0.32.3...v0.32.4) Updates `k8s.io/component-base` from 0.32.3 to 0.32.4 - [Commits](kubernetes/component-base@v0.32.3...v0.32.4) --- updated-dependencies: - dependency-name: k8s.io/api dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes - dependency-name: k8s.io/apiextensions-apiserver dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes - dependency-name: k8s.io/apimachinery dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes - dependency-name: k8s.io/client-go dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes - dependency-name: k8s.io/code-generator dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes - dependency-name: k8s.io/component-base dependency-version: 0.32.4 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: kubernetes ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maya Barnea <mayab@il.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
No description provided.