Skip to content

[fix]: Add oc check to kubernetes-dev-env script #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025

Conversation

kfirtoledo
Copy link

Run 'oc' command in kubernetes-dev-env script only if the cluster is OpenShift by checking for the 'route.openshift.io' API group.

@kfirtoledo kfirtoledo requested review from elevran and shaneutt April 29, 2025 18:07
Copy link
Collaborator

@elevran elevran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits.
Please investigate the CICD failure.
/lgtm
/hold for CICD failure check

Signed-off-by: Kfir Toledo <kfir.toledo@ibm.com>
@shaneutt shaneutt merged commit df99a4b into neuralmagic:dev Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants