Do nothing if a previous transform is not be removed. (microsoft#1822)

exKAZUu · rozele · commit 14198a10666b · 2018-05-18T10:06:15.000-04:00
When a WPF app uses `react-navigation`, the conditions `transforms == null` and `_transforms.Length == 0` can hold in the `SetTransform` method. In this case, `SetProjectionMatrix` method is invoked even though `transforms` is `null`, then `NullPointerException` occurs. So, this PR changes `SetTransform` method to not invoke `SetProjectionMatrix` method if `_transforms.Remove(view) == false`. Close microsoft#1821
diff --git a/ReactWindows/ReactNative.Net46/UIManager/BaseViewManager.cs b/ReactWindows/ReactNative.Net46/UIManager/BaseViewManager.cs
@@ -42,9 +42,12 @@ public abstract class BaseViewManager<TFrameworkElement, TLayoutShadowNode> :
         [ReactProp("transform")]
         public void SetTransform(TFrameworkElement view, JArray transforms)
         {
-            if (transforms == null && _transforms.Remove(view))
+            if (transforms == null)
             {
-                ResetProjectionMatrix(view);
+                if (_transforms.Remove(view))
+                {
+                    ResetProjectionMatrix(view);
+                }
             }
             else
             {

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,12 @@ public abstract class BaseViewManager<TFrameworkElement, TLayoutShadowNode> :`
`42`	`42`	`[ReactProp("transform")]`
`43`	`43`	`public void SetTransform(TFrameworkElement view, JArray transforms)`
`44`	`44`	`{`
`45`		`- if (transforms == null && _transforms.Remove(view))`
	`45`	`+ if (transforms == null)`
`46`	`46`	`{`
`47`		`- ResetProjectionMatrix(view);`
	`47`	`+ if (_transforms.Remove(view))`
	`48`	`+ {`
	`49`	`+ ResetProjectionMatrix(view);`
	`50`	`+ }`
`48`	`51`	`}`
`49`	`52`	`else`
`50`	`53`	`{`