Skip to content

demo: add clipboard button functionality and relevant styling #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ezekiel-charo
Copy link
Contributor

@ezekiel-charo ezekiel-charo commented Jun 27, 2025

Add a "Copy to clipboard" button on the code component to enable one-click copying of snippets across the demo site.

Fixes #4826

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md and DEVELOPER.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (b5d5feb) to head (5d523bf).
Report is 108 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4845      +/-   ##
==========================================
+ Coverage   88.65%   89.49%   +0.83%     
==========================================
  Files         120      121       +1     
  Lines        3817     4796     +979     
  Branches      747      980     +233     
==========================================
+ Hits         3384     4292     +908     
- Misses        396      504     +108     
+ Partials       37        0      -37     
Flag Coverage Δ
e2e 89.49% <ø> (∅)
unit 89.49% <ø> (+0.83%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@quentinderoubaix
Copy link
Contributor

lgtm over all, just some minor comments

Add a "Copy to clipboard" button on the code component to enable one-click copying of  snippets across the demo site.

Fixes ng-bootstrap#4826
@ezekiel-charo ezekiel-charo force-pushed the demo/clipboard-button branch from 567f630 to 5d523bf Compare June 28, 2025 11:48
@quentinderoubaix quentinderoubaix merged commit db98bf0 into ng-bootstrap:master Jun 29, 2025
2 checks passed
@ezekiel-charo ezekiel-charo deleted the demo/clipboard-button branch June 29, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Demo site] Suggestion: Add "Copy to clipboard" button to code snippets
3 participants