[Proposal] Ability to customize maintenance page #1532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melya
commented
Nov 13, 2020
| location @maintenance { | ||
| error_page 405 = /index.html; | ||
| add_header Cache-Control no-cache; | ||
| root /usr/share/nginx/html/maintenance; |
There was a problem hiding this comment.
Maybe one page is enough and root is redundant.
Had thoughts if somebody needs a place for css
There was a problem hiding this comment.
Thanks! I really need it, and wait for merge it!
Prime1Code
approved these changes
Apr 29, 2024
|
Superseded by #2430, comments are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nobody wants their service to be down, but when it happens, we want to make it in a more "happier" 🌈 way
Let's say instead of rendering
We could render some human readable page, like
P.S. _This is just a proposal.
I did a quick test and it works.
Would be great to here any feedback if it's relevant_