Skip to content

tests: Add tests for how Let's Encrypt ACME challenge is handled #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

p12tic
Copy link
Contributor

@p12tic p12tic commented May 4, 2024

At the moment no changes to functionality are done, only the current behavior is captured.

In the future I will suggest improvements in this area.

@p12tic p12tic force-pushed the test-acme-challenge branch 2 times, most recently from d0d185f to 5264127 Compare May 4, 2024 23:12
@buchdag buchdag added the type/test PR that add missing tests or correct existing tests label May 5, 2024
Copy link
Member

@buchdag buchdag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor test renaming request for consistency, other than that LGTM.

@p12tic p12tic force-pushed the test-acme-challenge branch from 5264127 to 4582f87 Compare May 6, 2024 10:06
At the moment no changes to functionality are done, only the current
behavior is captured.
@p12tic p12tic force-pushed the test-acme-challenge branch from 4582f87 to d6c38a0 Compare May 6, 2024 10:07
@buchdag buchdag merged commit f964176 into nginx-proxy:main May 6, 2024
@p12tic p12tic deleted the test-acme-challenge branch May 6, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/test PR that add missing tests or correct existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants