fix: use sha1 hash for config files name when using regex host #2533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ba7fd to
5affce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2529
As discussed in the issue, using
VIRTUAL_HOSTas basis for the file names nginx-proxy expects whenVIRTUAL_HOSTis a regex has the potential to render illegal characters in the nginx configuration.This PR make sure that when
VIRTUAL_HOSTis a regex, nginx-proxy expect files whose name are based on the sha1 hash of the regex instead.This might break previously working configuration, but I don't think there is another way around this, rendering regex characters in the config anywhere else than comments and the few directives that support them was a design error.