refactor: move $globals.ENV to $globals.config #2534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR create a corresponding entry in the
$globals.config
map for every$globals.ENV.*
value that where previously accessed throughout the template, so those global values can be displayed by the debug endpoint from #2525.The PR also try to cut down on some non idiomatic / hard to read stuff :
(foo (bar (buzz (qux "something"))))
, replaced byqux "something" | buzz | bar | foo
.coalesce
/or
to get a default value to a possibly null or empty one (coalesce "nullable" "defaultValue"
), replaced by"nullable" | default "defaultValue"
note: the boolean values in
$globals.config
that are used later in the template as a default global value to per-vhost one are currently strings rather than real booleans, and displayed as such in the debug endpoint. This is to avoid an additionalif
/else
/end
for each of those values when using them as fallback default.