Trap TERM to allow quicker exit of web containers #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to have had quite as dramatic an effect on CircleCI as it had locally... Let me know if you just want me to close it. Looks like it cut the test time from ~5:40 to ~4:40. Locally it cut it from ~3:20 to ~1:50. |
|
I see the same speed ups locally as well so definitely a worthwhile change. |
jwilder
added a commit
that referenced
this pull request
Oct 14, 2015
Trap TERM to allow quicker exit of web containers
|
Thanks @md5! |
|
Cool. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cut the test time roughly in half for me locally.