Any plans on merging this one into the master branch?

To make this more flexible, I changed the environment variable to be set at the individual container level.

This is awesome. I have been globally inserting ip_hash, but this change makes it possible per service. Please merge. :)

+1

Any update on whether this might be merged?

+1 to merge tpcwang commit

This is very useful. Sometimes I scale containers with docker-compose scale web=5 and I need to have ip_hash; to let users upload their files correctly. Actually, I override nginx.tmpl, but I have to update this file whenever jwilder releases a new version of his image.

Please, merge tpcwang commit.

For Docker-Compose, I have worked around this by changing the command that is run at container startup:

version: "2"

services:
  nginx:
    image: jwilder/nginx-proxy
    container_name: nginx
    volumes:
      - /var/run/docker.sock:/tmp/docker.sock:ro
    ports:
      - "8082:80"
    command: >
      bash -c "

      sed -i -e 's/^\(upstream .*\)/\1 \n     ip_hash;/g' nginx.tmpl ;
      forego start -r
      "

The sed command adds the ip_hash directive into the template's upstream section. This allows to just add the one change, without having to copy/map the whole template.

I need this feature too. Why this task still pending? we like tpcwang commit. please merge

@nwinkler the solution is good but sometime I only want to stick one service not all. Your option is hash all services.

I need this feature please resolve the conflicts :(

Hi,

as I needed this feature right here and now, but didn't have the time to make it a propert PR, I took @nwinkler's composer file and combined it with the informations provided by @tpcwang's pullrequest.
You only have to change @nwinkler's command part to:

command: >
      bash -c "
      sed -i -e 's/^\(upstream .*\)/{{ $$ip_hash := or (first (groupByKeys $$containers \"Env.USE_IP_HASH\")) \"0\" }}\n\n\1 \n{{ if ne $$ip_hash \"0\" }} \n     ip_hash;\n{{ end }}/g' nginx.tmpl ;
      forego start -r
      "

With this change in place, you can now select the ip affinity per service/container by setting the USE_IP_ENV variable to 1.

It's not the most elegant solution, but it should survive future updates to the nginx.tmpl. If I find the time, I'll probably try to takle the PR in the coming days/weeks, but I can't make any promises on that.

@ricktap

With this change in place, you can now select the ip affinity per service/container by setting the USE_IP_ENV variable to 1.

I think you meant USE_IP_HASH

+1 for this feature...

What is needed to merge this?

I managed to get this configured with a modifications on the script provided by @ricktap

Here is the script I used as entrypoint in the docker-compose file

#!/bin/bash
set -e
main() {
    template_file="/app/nginx.tmpl"
    if ! grep -q "ip_hash;" "$template_file"; then
        echo "Changing config..."
        sed -i -e 's/^\(upstream .*\)/{{ $ip_hash := or (first (groupByKeys .Containers \"Env.USE_IP_HASH\")) \"0\" }}\n\n\1 \n{{ if ne $ip_hash \"0\" }} \n     ip_hash;\n{{ end }}/g' $template_file
        echo "Change done. Starting..."
    else
        echo "File is already adapted. Starting..."
    fi
    forego start -r
}

main "$@"