Skip to content

Css selectors #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 35 commits into from
Closed

Css selectors #82

wants to merge 35 commits into from

Conversation

nielsdos
Copy link
Owner

@nielsdos nielsdos commented Jan 5, 2024 •
edited
Loading

  • test + rebase huidige changeset
  • importen nieuwe lexbor
  • importen nieuwe selector stuff
  • cleanup (incl TODOs fixen)
  • Support closest
  • Support those annoying quirks mode rules
  • Rebasen

https://app.codecov.io/github/nielsdos/php-src/tree/css-selectors/ext%2Fdom

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (master@c7ca3e5). Click here to learn what that means.

❗ Current head 1c69053 differs from pull request most recent head 6ca4ae2. Consider uploading reports for the commit 6ca4ae2 to get more accurate results

Files Patch % Lines
ext/dom/element.c 66.66% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #82   +/-   ##
=========================================
  Coverage          ?   71.07%           
=========================================
  Files             ?      822           
  Lines             ?   315170           
  Branches          ?        0           
=========================================
  Hits              ?   224013           
  Misses            ?    91157           
  Partials          ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielsdos nielsdos force-pushed the css-selectors branch 13 times, most recently from 821297d to dc9ed8a Compare January 10, 2024 21:31
@nielsdos nielsdos force-pushed the css-selectors branch 5 times, most recently from 1380fe1 to e1ee6b8 Compare March 24, 2024 20:49
@andypost
Copy link

Is it planned for 8.4? Any rfc ?

@nielsdos
Copy link
Owner Author

Is it planned for 8.4? Any rfc ?

I plan on doing one final DOM-related RFC for 8.4. It will include this PR + some others (php#13664 and php#13791 and some more that I didn't yet write code for).

@nielsdos
Copy link
Owner Author

Moving to php-src.

@nielsdos nielsdos closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Build System Extension: dom Extension: libxml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nielsdos @codecov-commenter @andypost