Better handle pathological filenames #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6af67cb to
2c9c2fc
Compare
Codecov Report
@@ Coverage Diff @@
## master #621 +/- ##
==========================================
+ Coverage 90.3% 90.31% +<.01%
==========================================
Files 87 87
Lines 10813 10816 +3
Branches 1793 1794 +1
==========================================
+ Hits 9765 9768 +3
Misses 719 719
Partials 329 329
Continue to review full report at Codecov.
|
os.path.splitext() does not provide the behavior we need to properly recognize edge cases such as '.nii' as image files.
2c9c2fc to
fc6a9c0
Compare
|
Makes world a better place so merging (looks kosher on cursory review), Thanks! |
|
Hello, I'm using nib.load(file_name) to access a ".nii.gz" file, and the function raise ImageFileError and I found that nib.filebasedimages.FileBasedImage.path_maybe_image('.nii') still gives me a (False, None). How can I solve the problem? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.splitext() does not provide the behavior we need to properly
recognize edge cases such as
.niias image files.Fixes #620