MRG: refactoring setup.py to fix sdist etc #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke setup.py sdist in the Python 3 refactor, because we were previously using a version of numpy.distutils build_py, and the refactor reverted (accidentally) to using the default disutils setup.py. We also forgot to add the new position of the fff files to the MANIFEST.in, so the sdist archives was broken.
Ship routine to make build_py command. Working towards allowing setup.py to run without nibabel.
Let setuptools do dependency checking when packages are not installed, or they are easy to install.
Using internal copy requires import from the nipy tree, which means that the needs to be importable when setup.py runs.
7bb2add to
3f71670
Compare
Don't preinstall packages, except numpy; let pip install dependencies for some tests.
3f71670 to
2727fe3
Compare
Nipy should add these as data in the various setup.py files, but this does not seem to be working. Add them explicitly in the MANIFEST.in
Data package message needed nibabel. Make this optional.
0b74dbb to
72df175
Compare
matthew-brett
added a commit
that referenced
this pull request
Oct 18, 2015
MRG: refactoring setup.py to fix sdist etc python setup.py sdist was broken, because I wasn't adding some files to the MANIFEST.in, and because I wasn't correctly using the numpy build_py command. In other news, it was annoying to have to install sympy etc to run python setup.py egg_info, which was in turn required when installing via pip - see gh-320. Fix both of these by dropping checks for Mayavi and Cython, dropping nibabel/nisext dependency (by copying code and refactoring), and letting setuptools take care of dependency checking for missing packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python setup.py sdist was broken, because I wasn't adding some files to the
MANIFEST.in, and because I wasn't correctly using the numpy build_py command.
In other news, it was annoying to have to install sympy etc to run python
setup.py egg_info, which was in turn required when installing via pip - see
gh-320.
Fix both of these by dropping checks for Mayavi and Cython, dropping
nibabel/nisext dependency (by copying code and refactoring), and letting
setuptools take care of dependency checking for missing packages.