Apply ruff rules (RUF) #574
Conversation
| @@ -190,7 +192,7 @@ def test_ec(): | |||
| assert_almost_equal(f(box1), 1) | |||
| # While we're here, test we can use different dtypes, and that values | |||
| # other than 0 or 1 raise an error. | |||
| for dtt in sum([np.sctypes[t] for t in ('int', 'uint', 'float')], []): | |||
| for dtt in functools.reduce(operator.iadd, [np.sctypes[t] for t in ('int', 'uint', 'float')], []): | |||
There was a problem hiding this comment.
This is definitely not more readable. I'd be okay to switching to chain.from_iterable from itertools, though.
There was a problem hiding this comment.
Actually, quadratic-list-summation (RUF017) is not about readability:
The use of
sum()to flatten lists of lists is quadratic in the number of lists, assum()creates a new list for each element in the summation.Instead, consider using another method of flattening lists to avoid quadratic complexity. The following methods are all linear in the number of lists:
functools.reduce(operator.iadd, lists, [])list(itertools.chain.from_iterable(lists))[item for sublist in lists for item in sublist]
But then that's hardly an issue for these small lists.
RUF010 Use explicit conversion flag
6159138 to
05f160f
Compare
RUF017 Avoid quadratic list summation
I001 Import block is un-sorted or un-formatted
05f160f to
0fe9a03
Compare
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
dbba8ae to
8e10c2c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 293 293
Lines 27479 27481 +2
Branches 3362 3363 +1
=======================================
+ Hits 23252 23254 +2
Misses 3273 3273
Partials 954 954 ☔ View full report in Codecov by Sentry. |
No description provided.