-
Notifications
You must be signed in to change notification settings - Fork 145
extend-select
and additional ruff rules
#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DimitriPapadopoulos
wants to merge
14
commits into
nipy:main
Choose a base branch
from
DimitriPapadopoulos:extend-select
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5973912
to
eefd30e
Compare
F507 `%`-format string has 1 placeholder(s) but 2 substitution(s)
F541 f-string without any placeholders
F811 Redefinition of unused function
E701 Multiple statements on one line (colon)
E702 Multiple statements on one line (semicolon)
E703 Statement ends with an unnecessary semicolon
E711 Comparison to `None` should be `is None`
E714 Test for object identity should be `is not`
W191 Indentation contains tabs
W605 Invalid escape sequence: `\.`
SIM103 Return the negated condition directly
PERF401 Use `list.extend` to create a transformed list
RUF022 `__all__` is not sorted
eefd30e
to
488466d
Compare
Add a few rules in the process.
488466d
to
b01fe7f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage 84.66% 84.66%
=======================================
Files 294 294
Lines 27452 27467 +15
Branches 3154 3149 -5
=======================================
+ Hits 23243 23256 +13
- Misses 3265 3267 +2
Partials 944 944 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.