Skip to content

[ENH] Improved PEP8 Compliance for interfaces/spm #1593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Aug 29, 2016
Merged

[ENH] Improved PEP8 Compliance for interfaces/spm #1593

merged 16 commits into from
Aug 29, 2016

Conversation

mgclark
Copy link
Contributor

@mgclark mgclark commented Aug 29, 2016

This PR improves the PEP8 compliance of interfaces/spm and is a partial fix for Issue #597.

The initial PR includes the following:

File            Violations       Resolved      Remain
base.py         13               13 (100%)     0
model.py        115              107 (93%)     8
preprocess.py   151              142 (94%)     9
utils.py        8                8 (100%)      0

Some long docstring lines remain; wrapping them made CircleCI unhappy. Even with those lines remaining, the readability of the code has been dramatically improved.

@coveralls
Copy link

coveralls commented Aug 29, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 72.231% when pulling 8424b80 on mgclark:pep8/spm into fd4dbde on nipy:master.

@satra satra merged commit da1f544 into nipy:master Aug 29, 2016
@satra
Copy link
Member

satra commented Aug 29, 2016

thanks for this @mgclark

@satra satra mentioned this pull request Aug 30, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgclark @coveralls @satra