DVARS fix & improvements #1827
Merged
DVARS fix & improvements #1827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oesteban
approved these changes
Feb 21, 2017
|
@chrisfilo - needs remerge |
oesteban
approved these changes
Feb 22, 2017
nipype/algorithms/confounds.py
Outdated
| warnings.filterwarnings('error') | ||
|
|
||
| # voxelwise standardization | ||
| diff_vx_stdz = np.square(func_diff) / np.array([diff_sdhat] * func_diff.shape[-1]).T | ||
| diff_vx_stdz = np.square( |
There was a problem hiding this comment.
**2 would be more readable to me than np.square, but it is just cosmetic. Maybe you prefer np.square :)
Codecov Report
@@ Coverage Diff @@
## master #1827 +/- ##
==========================================
+ Coverage 72.71% 72.71% +<.01%
==========================================
Files 1059 1059
Lines 52550 52556 +6
==========================================
+ Hits 38211 38217 +6
Misses 14339 14339
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1821.