Skip to content

Conversation

satra
Copy link
Member

@satra satra commented May 5, 2017

No description provided.

satra added 2 commits May 5, 2017 14:59
* upstream/master:
  fix: update autotests
  fix: typo
  fix: clean up tests and help messages
  fix: ensure outputspec is derived from outputspec
  fix: clean auto tests and white spaces
  fix: refactor compcor to not assign to self.inputs and re-use common functions
  rename and add scale file to template fix website typo remove afni jokes
  fix failing doctest
  added afni 3dUnifize to utils
@codecov-io
Copy link

codecov-io commented May 5, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@8d38c21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1997   +/-   ##
=========================================
  Coverage          ?   72.15%           
=========================================
  Files             ?     1117           
  Lines             ?    56456           
  Branches          ?     8112           
=========================================
  Hits              ?    40736           
  Misses            ?    14443           
  Partials          ?     1277
Flag Coverage Δ
#smoketests 72.15% <ø> (?)
#unittests 69.72% <ø> (?)
Impacted Files Coverage Δ
nipype/interfaces/mipav/developer.py 100% <ø> (ø)
nipype/interfaces/niftyseg/em.py 92.3% <ø> (ø)
.../interfaces/niftyseg/tests/test_auto_UnaryStats.py 85.71% <ø> (ø)
...interfaces/niftyseg/tests/test_auto_BinaryStats.py 85.71% <ø> (ø)
nipype/interfaces/niftyseg/maths.py 78.88% <ø> (ø)
nipype/interfaces/base.py 83.77% <ø> (ø)
nipype/interfaces/niftyseg/label_fusion.py 57.46% <ø> (ø)
nipype/interfaces/niftyseg/lesions.py 100% <ø> (ø)
...nterfaces/niftyseg/tests/test_auto_StatsCommand.py 85.71% <ø> (ø)
nipype/interfaces/niftyseg/stats.py 63.82% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d38c21...fb61822. Read the comment docs.

@effigies
Copy link
Member

effigies commented May 5, 2017

I take it this is meant to resolve the issue that's causing all Circle builds to fail?

@satra
Copy link
Member Author

satra commented May 5, 2017

@effigies - yes. so we should merge this once tests pass.

however, i snuck in one change. requires no longer raises warnings.

@effigies
Copy link
Member

effigies commented May 5, 2017

Cancelled the previous build to move this one up in the queue (and because that one was going to fail anyway). If you want to merge master/rebase now, then we'll get test results on the latest merges, too.

@satra
Copy link
Member Author

satra commented May 5, 2017

current master is merged in here.

@effigies
Copy link
Member

effigies commented May 5, 2017

So it is.

@satra satra merged commit f39e222 into nipy:master May 6, 2017
@satra satra deleted the fix/niftydocs branch October 30, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants