FIX: Do not generate filename when required fields are missing #2549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2549 +/- ##
==========================================
+ Coverage 67.08% 67.09% +<.01%
==========================================
Files 332 332
Lines 42509 42510 +1
Branches 5264 5266 +2
==========================================
+ Hits 28518 28521 +3
+ Misses 13289 13288 -1
+ Partials 702 701 -1
Continue to review full report at Codecov.
|
|
This is ready for review, though an unrelated test timed out. I wonder if these intermittent timeouts are related to #2548. |
cc03947 to
1d2a5c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2506.
Changes proposed in this pull request
name_sourcewhen required fields are missingThis doesn't address the situation where
name_source='in_files', butrequiresdoes not include'in_files'. Is it always desired that an undefinedname_sourceimplies an undefined derivative trait, or should we requirerequiresto ensure this behavior?Will add tests.