[ENH] Minor improvements to PR template #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Pull-request guidelines ----------------------- 1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file. 2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license. 3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress) 4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request) 5. Run `make check-before-commit` before submitting the PR. --> ## Summary <!-- Please reference any related issue and use fixes/close to automatically close them, if pertinent --> After our experience with https://github.com/poldracklab/fmriprep/blob/master/docs/pull_request_template.md, I apply here @effigies suggestion of using HTML comments, and add a checkbox for the license. Please, have a look into FMRIPREP's template to decide whether we want to import any more ideas into nipype. ## List of changes proposed in this PR (pull-request) <!-- We suggest using bullets (indicated by * or -) and filled checkboxes [x] here --> - [x] Use HTML comments in the PR template to avoid asking contributors to remove text. ## Acknowledgment - [x] \(Mandatory\) I acknowledge that this contribution will be available under the Apache 2 license.
Codecov Report
@@ Coverage Diff @@
## master #2636 +/- ##
======================================
Coverage 67.6% 67.6%
======================================
Files 340 340
Lines 43003 43003
Branches 5321 5321
======================================
Hits 29071 29071
+ Misses 13233 13225 -8
- Partials 699 707 +8
Continue to review full report at Codecov.
|
mgxd
approved these changes
Jul 13, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| <!-- | ||
|
|
||
| Pull-request guidelines | ||
| ----------------------- | ||
|
|
||
| 1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file. | ||
| 2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license. | ||
| 3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress) | ||
| 4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request) |
There was a problem hiding this comment.
We can remove 4) as this is now scripted
satra
approved these changes
Jul 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After our experience with https://github.com/poldracklab/fmriprep/blob/master/docs/pull_request_template.md, I apply here @effigies' suggestion of using HTML comments, and add a checkbox for the license.
Please, have a look into FMRIPREP's template to decide whether we want to import any more ideas into nipype.
List of changes proposed in this PR (pull-request)
Acknowledgment