FIX: Incorrect extension identified when checking File traits
#2987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewritten the validation of filename extensions, as it was incorrectly interpreting the extension. Fixes nipy#2984.
Codecov Report
@@ Coverage Diff @@
## master #2987 +/- ##
==========================================
- Coverage 67.6% 64.24% -3.36%
==========================================
Files 344 342 -2
Lines 43802 43747 -55
Branches 5478 5475 -3
==========================================
- Hits 29611 28106 -1505
- Misses 13475 14553 +1078
- Partials 716 1088 +372
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten the validation of filename extensions, as it was incorrectly
interpreting the extension.
Fixes #2984.