[FIX] check for existance of NULL file #2998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 67.49% 63.73% -3.77%
==========================================
Files 344 342 -2
Lines 44036 43984 -52
Branches 5554 5553 -1
==========================================
- Hits 29724 28032 -1692
- Misses 13568 14861 +1293
- Partials 744 1091 +347
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #2998 +/- ##
==========================================
- Coverage 67.49% 63.73% -3.77%
==========================================
Files 344 342 -2
Lines 44036 43984 -52
Branches 5554 5553 -1
==========================================
- Hits 29724 28032 -1692
- Misses 13568 14861 +1293
- Partials 744 1091 +347
Continue to review full report at Codecov.
|
|
I believe this shouldn't be a problem after #2971 was merged. Could you perhaps write a test? |
|
I don't think it's related to #2971. I tried to write a test case, which led me to the conclusion that it's probably not an issue anyway. Even if a file named 'NULL' exists, ants will fail to read it because it has no suffix. While I dislike using a fake file name to indicate no mask, that's really a problem with ANTS and not nipype. |
|
@stilley2 I'm not sure whether to interpret your last post as saying this change is not necessary. If so please close it. Otherwise, are you ready for a review or still working on the failing tests? |
|
Sorry for the ambiguity. Yes, I don't think this change is necessary. |
|
Great, thanks for the confirmation. |
Summary
The antsRegistration interfaces uses "NULL" to indicate no mask file. This will fail if there actually is a file named NULL. This PR checks for the existence of such a file and raises an exception if it exists.
List of changes proposed in this PR (pull-request)
Acknowledgment