Skip to content

FIX: Warn for min/max_ver traits when tool version can't be parsed #3241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 16, 2020
Merged

FIX: Warn for min/max_ver traits when tool version can't be parsed #3241

merged 4 commits into from
Aug 16, 2020

Conversation

effigies
Copy link
Member

Summary

@TheChymera Apologies for taking over #3234, but I would like to get a bug-fix release out quickly.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

satra
satra reviewed Aug 16, 2020
View reviewed changes
@effigies
Copy link
Member Author

@satra Updated.

@codecov
Copy link

codecov bot commented Aug 16, 2020 •
edited
Loading

Codecov Report

Merging #3241 into maint/1.5.x will increase coverage by 0.11%.
The diff coverage is 88.88%.

Impacted file tree graph

@@               Coverage Diff               @@
##           maint/1.5.x    #3241      +/-   ##
===============================================
+ Coverage        64.93%   65.04%   +0.11%     
===============================================
  Files              302      302              
  Lines            39823    39955     +132     
  Branches          5279     5282       +3     
===============================================
+ Hits             25858    25988     +130     
- Misses           12895    12896       +1     
- Partials          1070     1071       +1
Flag Coverage Δ
#unittests 65.04% <88.88%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/base/core.py 83.85% <88.88%> (+0.58%) ⬆️
nipype/interfaces/minc/minc.py 85.18% <0.00%> (+0.01%) ⬆️
nipype/interfaces/fsl/preprocess.py 71.44% <0.00%> (+0.03%) ⬆️
nipype/interfaces/ants/registration.py 73.09% <0.00%> (+0.05%) ⬆️
nipype/interfaces/base/specs.py 89.28% <0.00%> (+0.05%) ⬆️
nipype/interfaces/base/traits_extension.py 88.29% <0.00%> (+0.06%) ⬆️
nipype/utils/filemanip.py 72.94% <0.00%> (+0.06%) ⬆️
nipype/testing/fixtures.py 98.70% <0.00%> (+0.09%) ⬆️
nipype/interfaces/niftyreg/regutils.py 80.76% <0.00%> (+0.09%) ⬆️
nipype/interfaces/niftyreg/reg.py 86.00% <0.00%> (+0.09%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a775b...bf24dba. Read the comment docs.

@effigies effigies merged commit 946519c into nipy:maint/1.5.x Aug 16, 2020
@effigies effigies deleted the versioncheck branch August 16, 2020 17:34
@effigies effigies added this to the 1.5.1 milestone Aug 16, 2020
@TheChymera
Copy link
Collaborator

@effigies no worries, in fact, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satra satra satra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@effigies @TheChymera @satra