Skip to content

CI: Add specs and style checks #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 5, 2021
Merged

CI: Add specs and style checks #3321

merged 7 commits into from
Apr 5, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Apr 1, 2021

Summary

This PR should be reviewed commit-by-commit. The issues I was having previously were with mismatched versions of black installed in my dev environment and the precommit venv.

List of changes proposed in this PR (pull-request)

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies
Copy link
Member Author

effigies commented Apr 1, 2021

The .git-blame-ignore-revs is useful for local blame, but TBH I mainly use blame via GitHub. Watching this thread in hopes that it gets built-in to GitHub.

@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #3321 (29e2760) into master (467183e) will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3321   +/-   ##
=======================================
  Coverage   65.00%   65.00%           
=======================================
  Files         302      302           
  Lines       40027    40027           
  Branches     5292     5292           
=======================================
  Hits        26021    26021           
  Misses      12934    12934           
  Partials     1072     1072
Flag Coverage Δ
unittests 64.70% <71.42%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/algorithms/metrics.py 56.28% <ø> (ø)
nipype/algorithms/misc.py 45.24% <ø> (ø)
nipype/algorithms/modelgen.py 59.25% <ø> (ø)
nipype/algorithms/rapidart.py 34.42% <ø> (ø)
nipype/caching/memory.py 57.37% <ø> (ø)
nipype/info.py 87.50% <ø> (ø)
nipype/interfaces/ants/base.py 73.46% <ø> (ø)
nipype/interfaces/base/core.py 85.48% <ø> (ø)
nipype/interfaces/base/specs.py 89.28% <ø> (ø)
nipype/interfaces/base/support.py 79.53% <ø> (ø)
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467183e...29e2760. Read the comment docs.

@effigies effigies merged commit 6c06030 into master Apr 5, 2021
@effigies effigies deleted the ci/contrib branch April 5, 2021 12:54
@effigies effigies added this to the 1.6.1 milestone May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
1 participant
@effigies