Skip to content

Fix a bug about wrong order of function arguments #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

LostBenjamin
Copy link
Contributor

Hi,

This pull request is a fix to a potential bug about wrong order of function arguments at nipype/interfaces/fsl/utils.py. Please check the changes.

Best,
Jingxuan

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3485 (6aafc5b) into master (f4343d6) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3485      +/-   ##
==========================================
- Coverage   65.25%   65.11%   -0.15%     
==========================================
  Files         309      309              
  Lines       40848    40848              
  Branches     5378     5378              
==========================================
- Hits        26657    26597      -60     
- Misses      13117    13157      +40     
- Partials     1074     1094      +20     
Flag Coverage Δ
unittests 65.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nipype/interfaces/fsl/utils.py 64.46% <0.00%> (ø)
nipype/interfaces/r.py 45.83% <0.00%> (-37.51%) ⬇️
nipype/interfaces/freesurfer/base.py 69.35% <0.00%> (-7.26%) ⬇️
nipype/pkg_info.py 75.00% <0.00%> (-6.25%) ⬇️
nipype/interfaces/cat12/surface.py 63.73% <0.00%> (-2.20%) ⬇️
nipype/interfaces/afni/base.py 67.96% <0.00%> (-1.57%) ⬇️
nipype/pipeline/engine/base.py 84.84% <0.00%> (-1.52%) ⬇️
nipype/interfaces/cat12/preprocess.py 72.98% <0.00%> (-1.15%) ⬇️
nipype/interfaces/spm/preprocess.py 49.43% <0.00%> (-0.85%) ⬇️
nipype/pipeline/engine/nodes.py 78.43% <0.00%> (-0.64%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4343d6...6aafc5b. Read the comment docs.

Copy link
Member

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me - thanks for the PR!

@effigies
Copy link
Member

Please merge/rebase on master.

@effigies
Copy link
Member

Eh, I'm confident this isn't causing the failures. Merging.

@effigies effigies merged commit c7824a3 into nipy:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants