Skip to content

STY: Apply ruff rules (RUF) #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nipype/interfaces/ants/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@
)

__all__ = [
"AffineInitializer",
"AI",
"ANTS",
"AffineInitializer",
"AntsJointFusion",
"ApplyTransforms",
"ApplyTransformsToPoints",
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/base/support.py
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
class RuntimeContext(AbstractContextManager):
"""A context manager to run NiPype interfaces."""

__slots__ = ("_runtime", "_resmon", "_ignore_exc")
__slots__ = ("_ignore_exc", "_resmon", "_runtime")

def __init__(self, resource_monitor=False, ignore_exception=False):
"""Initialize the context manager object."""
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/slicer/generate_classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@
output_spec = %module_name%OutputSpec
_cmd = "%launcher% %name% "
%output_filenames_code%\n"""
template += f" _redirect_x = {str(redirect_x)}\n"
template += f" _redirect_x = {redirect_x}\n"

Check warning on line 434 in nipype/interfaces/slicer/generate_classes.py

View check run for this annotation

Codecov / codecov/patch

nipype/interfaces/slicer/generate_classes.py#L434

Added line #L434 was not covered by tests

main_class = (
template.replace("%class_str%", class_string)
Expand Down
2 changes: 1 addition & 1 deletion nipype/interfaces/spm/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,7 @@ def _generate_job(self, prefix="", contents=None):
if isinstance(contents, (str, bytes)):
jobstring += f"{prefix} = '{contents}';\n"
return jobstring
jobstring += f"{prefix} = {str(contents)};\n"
jobstring += f"{prefix} = {contents};\n"
return jobstring

def _make_matlab_command(self, contents, postscript=None):
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ def _local_hash_check(self, jobid, graph):
if (
cached
and updated
and (overwrite is False or overwrite is None and not always_run)
and (overwrite is False or (overwrite is None and not always_run))
):
logger.debug(
"Skipping cached node %s with ID %s.", self.procs[jobid], jobid
Expand Down Expand Up @@ -618,7 +618,7 @@ def _get_args(self, node, keywords):
else:
tmp_value = node.plugin_args[keyword]

if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
value = tmp_value
else:
value += tmp_value
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/condor.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(self, **kwargs):
"""
self._retry_timeout = 2
self._max_tries = 2
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -71,7 +71,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._qsub_args:
qsubargs = self._qsub_args
if "qsub_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
qsubargs = node.plugin_args["qsub_args"]
else:
qsubargs += " " + node.plugin_args["qsub_args"]
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/lsf.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __init__(self, **kwargs):
self._retry_timeout = 2
self._max_tries = 2
self._bsub_args = ""
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -70,7 +70,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._bsub_args:
bsubargs = self._bsub_args
if "bsub_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
bsubargs = node.plugin_args["bsub_args"]
else:
bsubargs += " " + node.plugin_args["bsub_args"]
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/oar.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def __init__(self, **kwargs):
self._retry_timeout = 2
self._max_tries = 2
self._max_jobname_length = 15
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "oarsub_args" in kwargs["plugin_args"]:
self._oarsub_args = kwargs["plugin_args"]["oarsub_args"]
if "retry_timeout" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -75,7 +75,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._oarsub_args:
oarsubargs = self._oarsub_args
if "oarsub_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
oarsubargs = node.plugin_args["oarsub_args"]
else:
oarsubargs += " " + node.plugin_args["oarsub_args"]
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/pbs.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def __init__(self, **kwargs):
self._retry_timeout = 2
self._max_tries = 2
self._max_jobname_length = 15
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -73,7 +73,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._qsub_args:
qsubargs = self._qsub_args
if "qsub_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
qsubargs = node.plugin_args["qsub_args"]
else:
qsubargs += " " + node.plugin_args["qsub_args"]
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/sge.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ def __init__(self, **kwargs):
instant_qstat = "qstat"
cached_qstat = "qstat"

if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -428,7 +428,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._qsub_args:
qsubargs = self._qsub_args
if "qsub_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
qsubargs = node.plugin_args["qsub_args"]
else:
qsubargs += " " + node.plugin_args["qsub_args"]
Expand Down
2 changes: 1 addition & 1 deletion nipype/pipeline/plugins/sgegraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class SGEGraphPlugin(GraphPluginBase):
def __init__(self, **kwargs):
self._qsub_args = ""
self._dont_resubmit_completed_jobs = False
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
plugin_args = kwargs["plugin_args"]
if "template" in plugin_args:
self._template = plugin_args["template"]
Expand Down
4 changes: 2 additions & 2 deletions nipype/pipeline/plugins/slurm.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ def __init__(self, **kwargs):
self._sbatch_args = None
self._jobid_re = "Submitted batch job ([0-9]*)"

if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down Expand Up @@ -100,7 +100,7 @@ def _submit_batchtask(self, scriptfile, node):
if self._sbatch_args:
sbatch_args = self._sbatch_args
if "sbatch_args" in node.plugin_args:
if "overwrite" in node.plugin_args and node.plugin_args["overwrite"]:
if node.plugin_args.get("overwrite"):
sbatch_args = node.plugin_args["sbatch_args"]
else:
sbatch_args += " " + node.plugin_args["sbatch_args"]
Expand Down
2 changes: 1 addition & 1 deletion nipype/pipeline/plugins/slurmgraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class SLURMGraphPlugin(GraphPluginBase):

def __init__(self, **kwargs):
self._sbatch_args = ""
if "plugin_args" in kwargs and kwargs["plugin_args"]:
if kwargs.get("plugin_args"):
if "retry_timeout" in kwargs["plugin_args"]:
self._retry_timeout = kwargs["plugin_args"]["retry_timeout"]
if "max_tries" in kwargs["plugin_args"]:
Expand Down
2 changes: 1 addition & 1 deletion nipype/pipeline/plugins/tools.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def report_crash(node, traceback=None, hostname=None):
login_name = getpass.getuser()
except KeyError:
login_name = f"UID{os.getuid():d}"
crashfile = f"crash-{timeofcrash}-{login_name}-{name}-{str(uuid.uuid4())}"
crashfile = f"crash-{timeofcrash}-{login_name}-{name}-{uuid.uuid4()}"
crashdir = node.config["execution"].get("crashdump_dir", os.getcwd())

os.makedirs(crashdir, exist_ok=True)
Expand Down
4 changes: 2 additions & 2 deletions nipype/utils/filemanip.py
Original file line number Diff line number Diff line change
Expand Up @@ -716,14 +716,14 @@ def write_rst_header(header, level=0):
def write_rst_list(items, prefix=""):
out = []
for item in ensure_list(items):
out.append(f"{prefix} {str(item)}")
out.append(f"{prefix} {item}")
return "\n".join(out) + "\n\n"


def write_rst_dict(info, prefix=""):
out = []
for key, value in sorted(info.items()):
out.append(f"{prefix}* {key} : {str(value)}")
out.append(f"{prefix}* {key} : {value}")
return "\n".join(out) + "\n\n"


Expand Down
2 changes: 1 addition & 1 deletion nipype/utils/nipype_cmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
try:
setattr(interface.inputs, input_name, value)
except ValueError as e:
print(f"Error when setting the value of {input_name}: '{str(e)}'")
print(f"Error when setting the value of {input_name}: '{e}'")

Check warning on line 55 in nipype/utils/nipype_cmd.py

View check run for this annotation

Codecov / codecov/patch

nipype/utils/nipype_cmd.py#L55

Added line #L55 was not covered by tests

print(interface.inputs)
res = interface.run()
Expand Down