Slicer _cmd revision and quotes around %s #3724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2918
List of changes proposed in this PR (pull-request)
changed the command line string used to call the BRAINSresample utility that is included in 3D Slicer. The master branch version will not properly call the BRAINSresample utility if the user's PATH does not specifically include the full path to the command line utility. Using "Slicer --launch <name_of_Slicer_command_line_utility>" is the correct way to call it.
add quotation marks (with escape sequence ") to the format specifier argument when parsing file path inputs, in order to allow filenames with spaces in them.