Skip to content

ENH: Load ITK's .mat files with Affine's loaders #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Conversation

oesteban
Copy link
Collaborator

Resolves a bug that disabled loading ITK matlab files unless you used the low-level io utility.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (8b31bf2) 98.58% compared to head (9b8c363) 98.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
+ Coverage   98.58%   98.59%   +0.01%     
==========================================
  Files          13       13              
  Lines        1268     1279      +11     
  Branches      182      184       +2     
==========================================
+ Hits         1250     1261      +11     
  Misses         10       10              
  Partials        8        8              
Flag Coverage Δ
travis 96.95% <100.00%> (+0.02%) ⬆️
unittests 98.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nitransforms/io/fsl.py 91.74% <100.00%> (ø)
nitransforms/io/itk.py 100.00% <100.00%> (ø)
nitransforms/linear.py 97.12% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

oesteban added 2 commits July 10, 2023 18:13
After all, it is ``linear.load()`` where the downcast to ``Affine``
happens if only one transform is in the array.
@oesteban oesteban merged commit 54ad1ea into master Jul 10, 2023
@oesteban oesteban deleted the fix/load-itk-mat branch July 10, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants