Skip to content

Conversation

oesteban
Copy link
Collaborator

@oesteban oesteban commented Aug 14, 2025

Replicates #270 (thanks @psadil) with a new unit test and squeezes the last dimension of the moving image if it is of size equals one.

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.58%. Comparing base (7772372) to head (01cb7cd).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage   95.56%   95.58%   +0.02%     
==========================================
  Files          16       16              
  Lines        1983     1995      +12     
  Branches      224      268      +44     
==========================================
+ Hits         1895     1907      +12     
  Misses         65       65              
  Partials       23       23              
Flag Coverage Δ
unittests 95.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oesteban oesteban force-pushed the codex/investigate-issue-#270-and-propose-tests branch from 431f2f2 to be5ddd6 Compare August 14, 2025 09:03
@oesteban oesteban changed the title test: reproduce 4D singleton resampling failure FIX: apply() fails with 4D singleton images Aug 14, 2025
@oesteban oesteban added the bug Something isn't working label Aug 14, 2025
@oesteban oesteban merged commit f663530 into master Aug 14, 2025
13 checks passed
@oesteban oesteban deleted the codex/investigate-issue-#270-and-propose-tests branch August 14, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resampling.apply chokes when transforming niftis that have fourth dimension equal to 1
2 participants