Skip to content

Conversation

oesteban
Copy link
Collaborator

Resolves: #270 .

Copy link

codecov bot commented Aug 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.59%. Comparing base (13b0a26) to head (0857139).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #279   +/-   ##
=======================================
  Coverage   95.58%   95.59%           
=======================================
  Files          16       16           
  Lines        1995     1996    +1     
  Branches      268      268           
=======================================
+ Hits         1907     1908    +1     
  Misses         65       65           
  Partials       23       23           
Flag Coverage Δ
unittests 95.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The shape of the output is defined by the reference shape in space, and by the input and the transform in the 4th dimension.
@oesteban oesteban requested a review from effigies August 15, 2025 06:33
Copy link
Member

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick look. It looks like to me, we just don't handle the 3D transform, 4D data case.

I couldn't quickly see how to handle it more generally, and this at least covers one particular case.

@oesteban
Copy link
Collaborator Author

Had a quick look. It looks like to me, we just don't handle the 3D transform, 4D data case.

I believe there are tests, but it should be cheap to ask to codex a little test for this so I will do so.

I couldn't quickly see how to handle it more generally, and this at least covers one particular case.

The rest of the combinations I'm positive we do have tests.

@oesteban oesteban merged commit 20e2c25 into master Aug 15, 2025
13 checks passed
@oesteban oesteban deleted the fix/finalize-270 branch August 15, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resampling.apply chokes when transforming niftis that have fourth dimension equal to 1
2 participants