relaxed task definition validation to accept use cases found in ANTs, FSL, Freesurfer, etc... task packages #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FSL, Freesurfer, etc... task packages
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 88.54% 88.44% -0.11%
==========================================
Files 86 86
Lines 17964 17988 +24
Branches 3504 3509 +5
==========================================
+ Hits 15907 15910 +3
- Misses 1680 1697 +17
- Partials 377 381 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Some of the use cases found when converting the ANTs, FSL, Freesurfer and AFNI task packages from Nipype were rejected by the existing task validation. This PR relaxes this validation to allow these valid cases
Checklist