Skip to content

FIX: Copy interface before running to prevent task mutation on run #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

FIX: Copy interface before running to prevent task mutation on run #12

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5a746c0
FIX: Copy interface before running to prevent task mutation on run
effigies Apr 15, 2021
3c4cc88
FIX: Use deepcopy
effigies Apr 15, 2021
9b2ff04
Merge branch 'main' into fix/no_mutate_on_run
effigies Oct 19, 2022
7fd9e72
Merge branch 'main' into fix/no_mutate_on_run
effigies Mar 23, 2024
0709a5e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 23, 2024
1df2696
Merge branch 'main' into fix/no_mutate_on_run
effigies May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pydra/tasks/nipype1/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import nipype
import attrs
import typing as ty
from copy import deepcopy

__all__ = ["Nipype1Task"]

Expand Down Expand Up @@ -70,7 +71,7 @@ def __init__(

def _run_task(self, environment=None):
inputs = attrs.asdict(self.inputs, filter=lambda a, v: v is not attrs.NOTHING)
node = nipype.Node(self._interface, base_dir=self.output_dir, name=self.name)
node = nipype.Node(deepcopy(self._interface), base_dir=self.output_dir, name=self.name)
node.inputs.trait_set(**inputs)
res = node.run()
self.output_ = res.outputs.get()