fix(deps): remove deprecated node-domexception dependency #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
approved these changes
May 28, 2025
jayvdb
reviewed
May 28, 2025
|
will this PR merge? |
YasharF
reviewed
Aug 4, 2025
|
@YasharF If this looks good to you, could you approve it? |
|
@jayvdb @YasharF @jimmywarting Just a friendly bump in case any of you has the time to review the updated PR |
|
I am not a maintainer. I don't think if node-fetch and related projects are being maintained anymore. You may want to consider switching to an alternate solution such as nodejs's builtin fetch api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is:
Remove dependency
node-domexceptionwhich is deprecated in favor of Node.js nativeDOMException(available since Node.js 17).This is what had to change:
>=16.7to>=17node-domexceptionfrom dependenciesThis is what reviewers should know:
Float16Arraytest failuredocs:,fix(area):,feat(area):orbreaking(area):