Skip to content

fix(addon-verify): await files writing #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

fix(addon-verify): await files writing #207

merged 2 commits into from
Mar 11, 2025

Conversation

araujogui
Copy link
Member

Description

Fix the missing await in the file writing promises

Validation

The output files were empty before the fix

Related Issues

Related to nodejs/node#57343

CC @flakey5

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I've covered new added functionality with unit tests if necessary.

@araujogui araujogui requested a review from a team as a code owner March 11, 2025 02:09
ovflowd
ovflowd approved these changes Mar 11, 2025
View reviewed changes
@araujogui araujogui merged commit d982333 into nodejs:main Mar 11, 2025
6 checks passed
@araujogui araujogui deleted the fix/addon-verify-promise branch March 11, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@flakey5 flakey5 flakey5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@araujogui @ovflowd @flakey5