-
Notifications
You must be signed in to change notification settings - Fork 2k
Add images for debian trixie #2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This change has a "soft conflict" with: So after one of them is merged, the other should be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but as it doesn't have an official release according to https://wiki.debian.org/DebianReleases, it seems like this is to early to land. I'll leave it open, but marking it as blocked
We had the same discussion on #1881 😅 Ok, let's change it to draft until it is released. |
Debian trixie is releasing on 9th August: https://wiki.debian.org/DebianTrixie |
Rebased and updated. |
Released! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I was actually going to bump this when I saw people talking about the release going out yesterday 😄 . Minor nit for the v20 files, other than that, LGTM
Updated the commit message and description following the release. |
Hey, can we get this out of the way? Most other languags like Python have trixie versions released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Debian Trixie (version 13) as a new base image variant for Node.js Docker containers. It includes both regular and slim variants for Node.js versions 20, 22, and 24, expanding architecture support to include amd64, arm64v8, ppc64le, and s390x platforms.
- Adds Debian Trixie configuration and architecture mappings
- Creates Dockerfiles and entrypoint scripts for trixie and trixie-slim variants across Node.js versions 20, 22, and 24
- Updates documentation to reference the new Debian Trixie variant
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
versions.json | Adds trixie and trixie-slim variant definitions with supported architectures |
config | Updates to include trixie in debian_versions and bumps alpine_version to 3.22 |
architectures | Maps trixie variants to supported CPU architectures |
SECURITY.md | Updates documentation to include trixie in Debian version list |
README.md | Adds documentation section for the new node:trixie variant |
24/trixie/, 22/trixie/, 20/trixie/* | Creates Dockerfiles and entrypoint scripts for trixie variants |
24/trixie-slim/, 22/trixie-slim/, 20/trixie-slim/* | Creates Dockerfiles and entrypoint scripts for trixie-slim variants |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@@ -1,4 +1,4 @@ | |||
baseuri https://nodejs.org/dist | |||
default_variant bookworm | |||
alpine_version 3.19 | |||
debian_versions bookworm bullseye | |||
alpine_version 3.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alpine_version update to 3.22 appears unrelated to adding Debian Trixie support. This change should be in a separate commit or PR to maintain clear separation of concerns.
alpine_version 3.22 | |
alpine_version 3.21 |
Copilot uses AI. Check for mistakes.
Created PR on the official-images repo (docker-library/official-images#19678). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub. |
Description
https://wiki.debian.org/DebianTrixie
Testing Details
Checked that it builds and runs.
Types of changes
Checklist