Skip to content

Add images for debian trixie #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2025
Merged

Add images for debian trixie #2253

merged 1 commit into from
Aug 13, 2025

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Jul 8, 2025

Description

https://wiki.debian.org/DebianTrixie

Testing Details

Checked that it builds and runs.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@orgads
Copy link
Contributor Author

orgads commented Jul 8, 2025

This change has a "soft conflict" with:

So after one of them is merged, the other should be updated.

@PeterDaveHello PeterDaveHello requested review from Copilot and a team July 10, 2025 18:05
Copilot

This comment was marked as outdated.

Copilot

This comment was marked as spam.

Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but as it doesn't have an official release according to https://wiki.debian.org/DebianReleases, it seems like this is to early to land. I'll leave it open, but marking it as blocked

@orgads
Copy link
Contributor Author

orgads commented Jul 11, 2025

We had the same discussion on #1881 😅

Ok, let's change it to draft until it is released.

@orgads orgads marked this pull request as draft July 11, 2025 09:50
@adityapatadia
Copy link

Debian trixie is releasing on 9th August: https://wiki.debian.org/DebianTrixie

@orgads
Copy link
Contributor Author

orgads commented Aug 4, 2025

Rebased and updated.

@orgads orgads marked this pull request as ready for review August 10, 2025 03:24
@orgads
Copy link
Contributor Author

orgads commented Aug 10, 2025

Released! 🎉

Copy link
Member

@nschonni nschonni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was actually going to bump this when I saw people talking about the release going out yesterday 😄 . Minor nit for the v20 files, other than that, LGTM

@orgads
Copy link
Contributor Author

orgads commented Aug 11, 2025

Updated the commit message and description following the release.

@adityapatadia
Copy link

Hey, can we get this out of the way? Most other languags like Python have trixie versions released.

@PeterDaveHello PeterDaveHello requested a review from Copilot August 13, 2025 16:05
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Debian Trixie (version 13) as a new base image variant for Node.js Docker containers. It includes both regular and slim variants for Node.js versions 20, 22, and 24, expanding architecture support to include amd64, arm64v8, ppc64le, and s390x platforms.

  • Adds Debian Trixie configuration and architecture mappings
  • Creates Dockerfiles and entrypoint scripts for trixie and trixie-slim variants across Node.js versions 20, 22, and 24
  • Updates documentation to reference the new Debian Trixie variant

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
versions.json Adds trixie and trixie-slim variant definitions with supported architectures
config Updates to include trixie in debian_versions and bumps alpine_version to 3.22
architectures Maps trixie variants to supported CPU architectures
SECURITY.md Updates documentation to include trixie in Debian version list
README.md Adds documentation section for the new node:trixie variant
24/trixie/, 22/trixie/, 20/trixie/* Creates Dockerfiles and entrypoint scripts for trixie variants
24/trixie-slim/, 22/trixie-slim/, 20/trixie-slim/* Creates Dockerfiles and entrypoint scripts for trixie-slim variants

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -1,4 +1,4 @@
baseuri https://nodejs.org/dist
default_variant bookworm
alpine_version 3.19
debian_versions bookworm bullseye
alpine_version 3.22
Copy link
Preview

Copilot AI Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alpine_version update to 3.22 appears unrelated to adding Debian Trixie support. This change should be in a separate commit or PR to maintain clear separation of concerns.

Suggested change
alpine_version 3.22
alpine_version 3.21

Copilot uses AI. Check for mistakes.

@PeterDaveHello PeterDaveHello merged commit fcc502e into nodejs:main Aug 13, 2025
18 checks passed
Copy link

Created PR on the official-images repo (docker-library/official-images#19678). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants