Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/github-bot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: nodejs/github-bot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: refactor-integration-tests
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Mar 26, 2019

  1. tests: refactor to prove integration tests w/nock scope fails 

    The most important changes introduced here is to make sure absolutely
*every* nock scope (read: outgoing HTTP request) gets asserted.

Previously that was not the case, as only the *first* nock scope was
verified, all the other ones has actually not been verified at all.

That's what these changes proves; no source code changes has been done,
it's only being sure that all nock scopes are actually verified.
    @phillipj
    phillipj committed Mar 26, 2019
    Configuration menu
    Copy the full SHA
    da38043 View commit details
    Browse the repository at this point in the history
Loading