Add support for polling Travis CI builds by SHA #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
8a4b30a to
5856c8a
Compare
Compared to the nodejs.org repo, Travis doesn't pick up newly created PR's from nodejs/readable-stream. Strangely enough it does pick up commits and builds them though. Therefore these changes adds support for polling Travis builds by commit SHAs rather than PR #id alone. The bot tries to do a smart choice about which polling to use by checking if Travis has had *any* builds triggered by PR's lately, if not if starts to poll by SHA.
5856c8a to
cf21a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to the nodejs.org repo, Travis doesn't pick up newly created PR's from nodejs/readable-stream. Strangely enough it does pick up commits and builds them though.
Therefore these changes adds support for polling Travis builds by commit SHAs rather than PR #id alone. The bot tries to do a smart choice about which polling to use by checking if Travis has had any builds triggered by PR's lately, if not if starts to poll by SHA.
Disclaimer for sore eyes: this introduces a lot of duplicated code between polling PR's and SHAs. I'd rather get this up-n-running and clean up the mess later.
Refs nodejs/readable-stream#194 (comment)