Skip to content

avoid using Buffer constructor #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019
Merged

avoid using Buffer constructor #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/trigger-jenkins-build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ function buildParametersForRepo (options, repo) {

function triggerBuild (options, cb) {
const { repo } = options
const base64Credentials = new Buffer(jenkinsApiCredentials).toString('base64')
const base64Credentials = Buffer.from(jenkinsApiCredentials, 'base64')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't toString() still need to be called?

This diff should make things ok, I believe:

Suggested change
const base64Credentials = Buffer.from(jenkinsApiCredentials, 'base64')
const base64Credentials = Buffer.from(jenkinsApiCredentials).toString('base64')

const authorization = `Basic ${base64Credentials}`

const jobName = getJobNameForRepo(repo)
Expand Down